From: Stefano Stabellini Date: Fri, 6 Mar 2015 17:19:14 +0000 (+0000) Subject: Revert "libxl: Wait for ballooning if free memory is increasing" X-Git-Tag: archive/raspbian/4.8.0-1+rpi1~1^2~3646 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/success//%22http:/www.example.com/cgi/success/?a=commitdiff_plain;h=b022d88b4dd4e176c447911f65208c12d5f9a903;p=xen.git Revert "libxl: Wait for ballooning if free memory is increasing" This reverts commit 2563bca11544361dc2afa5e20b5663e10a0715cb. Signed-off-by: Stefano Stabellini Reviewed-by: Mike Latimer Tested-by: Mike Latimer Acked-by: Ian Campbell --- diff --git a/tools/libxl/xl_cmdimpl.c b/tools/libxl/xl_cmdimpl.c index 5c40e840cf..f326df4c8a 100644 --- a/tools/libxl/xl_cmdimpl.c +++ b/tools/libxl/xl_cmdimpl.c @@ -2198,9 +2198,8 @@ static int preserve_domain(uint32_t *r_domid, libxl_event *event, static int freemem(uint32_t domid, libxl_domain_build_info *b_info) { - int rc, retries; - const int MAX_RETRIES = 3; - uint32_t need_memkb, free_memkb, free_memkb_prev = 0; + int rc, retries = 3; + uint32_t need_memkb, free_memkb; if (!autoballoon) return 0; @@ -2209,7 +2208,6 @@ static int freemem(uint32_t domid, libxl_domain_build_info *b_info) if (rc < 0) return rc; - retries = MAX_RETRIES; do { rc = libxl_get_free_memory(ctx, &free_memkb); if (rc < 0) @@ -2234,16 +2232,7 @@ static int freemem(uint32_t domid, libxl_domain_build_info *b_info) if (rc < 0) return rc; - /* - * If the amount of free mem has increased on this iteration (i.e. - * some progress has been made) then reset the retry counter. - */ - if (free_memkb > free_memkb_prev) { - retries = MAX_RETRIES; - free_memkb_prev = free_memkb; - } else { - retries--; - } + retries--; } while (retries > 0); return ERROR_NOMEM;